Skip to content

Added note around localization considerations for recovery phrases in the glossary - #753

Merged
GBKS merged 2 commits into
masterfrom
feature/localization-note-for-recovery-phrases
Apr 26, 2022
Merged

GBKS merged 2 commits into
masterfrom
feature/localization-note-for-recovery-phrases

Conversation

@GBKS

@GBKS GBKS commented Apr 7, 2022 •

Copy link
Copy Markdown
Contributor

If you're writing Japanese or other languages that are very different from English, then the words in a recovery phrase will look pretty foreign to you (might also have problems typing them back in if you're on a different language keyboard). Muun has gotten this feedback and it was a reason why they were more comfortable using output descriptors.

Not sure if the glossary is the right place for this, but I think it would be good to add this somewhere. Also wonder if we have any recommendations on what to do instead?

🦣Here's the preview🐢

If you're writing Japanese or other languages that are very different from English, then the words in a recovery phrase will look pretty foreign to you. Muun has gotten this feedback and it was a reason why they were more comfortable using output descriptors.

Not sure if the glossary is the right place for this, but I think it would be good to add this somewhere. Also wonder if we have any recommendations on what to do instead?
@GBKS GBKS added the Copy Task is about improving text. label Apr 7, 2022
@GBKS GBKS self-assigned this Apr 7, 2022
pavlenex
pavlenex previously approved these changes Apr 8, 2022
@pavlenex

pavlenex commented Apr 8, 2022

Copy link
Copy Markdown
Contributor

I think it's okay in glossary for now, would you want to add anything more to it, to me this looks like good enough addition, but I've sen you experimenting in Slack, so let me know.

@GBKS

GBKS commented Apr 8, 2022

Copy link
Copy Markdown
Contributor Author

Posted this on Slack and Twitter to get some more input.

BIP39 in japanese 220408

@GBKS
GBKS marked this pull request as draft April 8, 2022 12:46
@Bosch-0

Bosch-0 commented Apr 11, 2022

Copy link
Copy Markdown
Collaborator

Good suggestion, definitely need more accessibility content like this. I'd imagine this would suit better in the manual backup page in the daily spending wallet but a footnote on this in the glossary is also a good suggestion.

We should tackle adding this to the manual backup page when we get around to revising the daily spending wallet

@GBKS

GBKS commented Apr 13, 2022

Copy link
Copy Markdown
Contributor Author

Phoenix is working on this, and I opened an issue with Blue Wallet.

Due to the lack of current support, the Phoenix crew suggested to start with implementing import of localized recovery phrases. If we can get broad support there, we can implement their creation without having to worry that people will be stuck because they can't import their wallets.

BIP39 includes word lists in 10 languages, and there's a separate repo to collaborate around creating more. Not much activity there at the moment. 10 is probably good for now.

Looks like this could turn into a campaign like the unified QRs. Considering moving this effort out of this PR into a dedicated collaboration issue in meta.

@Bosch-0

Bosch-0 commented Apr 20, 2022

Copy link
Copy Markdown
Collaborator

Looks like this could turn into a campaign like the unified QRs. Considering moving this effort out of this PR into a dedicated collaboration issue in meta.

Let's do it, I'm keen to help out

@GBKS

GBKS commented Apr 20, 2022

Copy link
Copy Markdown
Contributor Author

The BlueWallet crew just merged support for this (meaning it supports 10 different languages of wordlists for wallet import now). What are some other wallets we could talk to about this?

@Bosch-0

Bosch-0 commented Apr 21, 2022

Copy link
Copy Markdown
Collaborator

Lets create an issue, make a wallet list in the OP, and start posting issues on their GitHubs to support importing. Looks like its an easy addition based on how fast BlueWallet implemented it. Once they can all import we can then suggest generation.

@GBKS

GBKS commented Apr 25, 2022

Copy link
Copy Markdown
Contributor Author

Created a collaboration issue for the broader campaign of supporting multi-language recovery phrases.

I will clean up this PR so it matches the original intent. Then we can create follow-up PRs for any changes and improvements.

Added notes to the recovery and manual backup pages.
Minor copy tweak to the glossary note.
@GBKS
GBKS marked this pull request as ready for review April 25, 2022 08:36
@GBKS

GBKS commented Apr 25, 2022 •

Copy link
Copy Markdown
Contributor Author

Pushed a small update to this. There are now hints at supporting multiple languages in three places:

Once more wallets support this, we should add a dedicated paragraph and screen mock-up to the Manual backup page. This will require some more design work to think through details like whether to use the default OS language, how to let users switch languages, etc.

And also switched this PR as ready for review now.

@sbddesign sbddesign left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GBKS
GBKS merged commit 3f908ce into master Apr 26, 2022
@sbddesign
sbddesign deleted the feature/localization-note-for-recovery-phrases branch April 28, 2022 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Copy Task is about improving text.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants